Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL to unitedstates.github.io #224

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Update URL to unitedstates.github.io #224

merged 3 commits into from
Jan 24, 2025

Conversation

konklone
Copy link
Member

@konklone konklone commented Jan 23, 2025

Tracking a PR with any changes needed to switch the URL.

  • Updated README.
  • Updated GPO script.
  • I'm acknowledging that my submission is free of all known copyright in at least
    the United States.
    (In general, works of the federal government should satisfy
    this criteria.)

Switching the URL in the documentation.
This switches the URL of fetched photos to use unitedstates.github.io
@konklone
Copy link
Member Author

OK, it looks like theunitedstates.io was referenced in the README and in one script designed to manage GPO-related sources. @kevinschaul Would you mind taking a look over to make sure this looks right?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

For others, here's the background: unitedstates/congress-legislators#972.

@@ -67,7 +67,7 @@ def get_legislators_current(br, include_historical=False):
increases the download size)
"""
legislators = br.get(
"https://theunitedstates.io/congress-legislators/legislators-current.json"
"https://unitedstates.github.io/congress-legislators/legislators-current.json"
Copy link
Member

@hugovk hugovk Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a https://theunitedstates.io/congress-legislators/ on line 74 to update as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed that as well.

Another URL change to unitedstates.github.io.
@hugovk hugovk merged commit 432053a into gh-pages Jan 24, 2025
14 checks passed
@hugovk hugovk deleted the konklone-patch-1 branch January 24, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants