Upgrade to ember-page-title@v8.2.0, which provides its own types now

universal-ember · Jan 8, 2024 · b1bb883 · b1bb883
1 parent ceccff4
commit b1bb883
Show file tree

Hide file tree

Showing 5 changed files with 52 additions and 16 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/min-supportetd/package.json b/tests/min-supportetd/package.json
@@ -62,7 +62,7 @@
     "ember-functions-as-helper-polyfill": "2.1.2",
     "ember-load-initializers": "^2.1.2",
     "ember-modifier": "^4.1.0",
-    "ember-page-title": "^8.1.0",
+    "ember-page-title": "^8.2.0",
     "ember-qunit": "^8.0.2",
     "ember-resolver": "^11.0.1",
     "ember-source": "~3.28.0",

diff --git a/tests/test-app/app/templates/application.hbs b/tests/test-app/app/templates/application.hbs
@@ -1,4 +1,3 @@
-{{! @glint-expect-error }}
 {{page-title "TestApp"}}
 
 <h2 id="title">Welcome to Ember</h2>

diff --git a/tests/test-app/package.json b/tests/test-app/package.json
@@ -23,7 +23,6 @@
     "lint:js:fix": "eslint . --fix",
     "lint:prettier": "prettier -c .",
     "lint:prettier:fix": "prettier -w .",
-    "lint:types": "glint",
     "_syncPnpm": "pnpm sync-dependencies-meta-injected",
     "start": "concurrently 'ember serve' 'pnpm _syncPnpm --watch' --names 'tests serve,tests sync deps'",
     "test:ember": "pnpm _syncPnpm && ember test --test-port 0"
@@ -64,7 +63,7 @@
     "ember-cli-inject-live-reload": "^2.1.0",
     "ember-load-initializers": "^2.1.2",
     "ember-modifier": "^4.1.0",
-    "ember-page-title": "^8.1.0",
+    "ember-page-title": "^8.2.0",
     "ember-qunit": "^8.0.2",
     "ember-resolver": "^11.0.1",
     "ember-source": "~5.4.0",

diff --git a/tests/test-app/types/global.d.ts b/tests/test-app/types/global.d.ts
@@ -1 +1,9 @@
 import '@glint/environment-ember-loose';
+
+import type PageTitle from 'ember-page-title/template-registry';
+
+declare module '@glint/environment-ember-loose/registry' {
+  export default interface Registry extends PageTitle {
+    /* your local loose-mode entries here */
+  }
+}