[REG-1273] - Code review fixes

unstoppabledomains · May 28, 2024 · b6771e1 · b6771e1
1 parent 64e7eb5
commit b6771e1
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 10 deletions.
diff --git a/contracts/marketplace/ISeaportProxyBuyer.sol b/contracts/marketplace/ISeaportProxyBuyer.sol
@@ -1,7 +1,7 @@
 // @author Unstoppable Domains, Inc.
 // @date April 25th, 2024
 
-pragma solidity 0.8.24;
+pragma solidity ^0.8.24;
 
 import {AdvancedOrder, CriteriaResolver} from 'seaport-types/src/lib/ConsiderationStructs.sol';
 

diff --git a/contracts/marketplace/SeaportProxyBuyer.sol b/contracts/marketplace/SeaportProxyBuyer.sol
@@ -1,7 +1,7 @@
 // @author Unstoppable Domains, Inc.
 // @date April 25th, 2024
 
-pragma solidity 0.8.24;
+pragma solidity ^0.8.24;
 
 import {Initializable} from '@openzeppelin/contracts-upgradeable/proxy/utils/Initializable.sol';
 import {ContextUpgradeable} from '@openzeppelin/contracts-upgradeable/utils/ContextUpgradeable.sol';

diff --git a/contracts/marketplace/_refs.sol b/contracts/marketplace/_refs.sol
@@ -1,7 +1,7 @@
 // @author Unstoppable Domains, Inc.
 // @date April 25th, 2024
 
-pragma solidity 0.8.24;
+pragma solidity ^0.8.24;
 
 import {Seaport} from 'seaport-core/src/Seaport.sol';
 import {ConduitController} from 'seaport-core/src/conduit/ConduitController.sol';
diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "compile": "hardhat compile --force;",
     "build:package": "yarn compile; rm -Rf dist/*; tsc --project tsconfig.build.json",
     "build:ci": "yarn build:package && yarn rebuild:sandbox && yarn copy:assets",
-    "copy:assets": "mkdir -p dist/sandbox/foundry/bin; cp sandbox/foundry/bin/gitkeep dist/sandbox/foundry/bin/gitkeep; cp sandbox/state.json dist/sandbox/; cp sandbox/foundry/foundryup.sh dist/sandbox/foundry; cp uns-config.json dist/; cp ens-config.json dist/;",
+    "copy:assets": "mkdir -p dist/sandbox/foundry/bin; cp sandbox/foundry/bin/.gitkeep dist/sandbox/foundry/bin/.gitkeep; cp sandbox/state.json dist/sandbox/; cp sandbox/foundry/foundryup.sh dist/sandbox/foundry; cp uns-config.json dist/; cp ens-config.json dist/;",
     "compile:size": "env ENABLE_CONTRACT_SIZER=true yarn compile",
     "coverage": "hardhat coverage",
     "test": "yarn test:sol && yarn test:sandbox",

diff --git a/sandbox/anvil-server.ts b/sandbox/anvil-server.ts
@@ -38,7 +38,7 @@ const ANVIL_ARGUMENTS_MAP: Record<Exclude<keyof AnvilServerOptions, 'anvilCliPat
   silent: '--silent',
 };
 
-const BLOCKS_TO_KEEP = 100;
+const BLOCKS_TO_KEEP = 500;
 
 export class AnvilServer {
   readonly options: Partial<AnvilServerOptions>;

diff --git a/sandbox/foundry/bin/.gitignore b/sandbox/foundry/bin/.gitignore
@@ -1,3 +1,3 @@
 *
 !.gitignore
-!gitkeep
+!.gitkeep
diff --git a/sandbox/foundry/bin/gitkeep → sandbox/foundry/bin/.gitkeep b/sandbox/foundry/bin/gitkeep → sandbox/foundry/bin/.gitkeep
diff --git a/tsconfig.json b/tsconfig.json
@@ -32,9 +32,6 @@
     "./test/**/*.ts",
   ],
   "exclude": [
-    "./sandbox/foundry/bin/anvil",
-    "./sandbox/foundry/bin/cast",
-    "./sandbox/foundry/bin/chisel",
-    "./sandbox/foundry/bin/forge",
+    "./sandbox/foundry/bin/*",
   ],
 }