Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1248] Sepolia, Amoy migration #330

Merged

Conversation

nickshatilo
Copy link
Member

@nickshatilo nickshatilo commented Apr 8, 2024

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@nickshatilo nickshatilo force-pushed the nickshatilo/REG-1248/deploy-smart-contracts-to-new-testnets branch 3 times, most recently from 2a44118 to c44d0ac Compare April 8, 2024 10:23
@nickshatilo nickshatilo requested review from a team and bonsaiben and removed request for a team and bonsaiben April 8, 2024 10:24
@nickshatilo nickshatilo self-assigned this Apr 8, 2024
@nickshatilo nickshatilo force-pushed the nickshatilo/REG-1248/deploy-smart-contracts-to-new-testnets branch 2 times, most recently from 6e426bb to d9b8bc8 Compare April 9, 2024 14:07
Copy link
Contributor

@DeRain DeRain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nickshatilo nickshatilo force-pushed the nickshatilo/REG-1248/deploy-smart-contracts-to-new-testnets branch from d9b8bc8 to 812b7fe Compare April 9, 2024 15:37
Copy link

github-actions bot commented Apr 9, 2024

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 19.75 0
ProxyReader 15.176 0
UNSRegistry 20.725 0

@nickshatilo nickshatilo merged commit f4ed3a2 into main Apr 9, 2024
8 checks passed
@nickshatilo nickshatilo deleted the nickshatilo/REG-1248/deploy-smart-contracts-to-new-testnets branch April 9, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants