[REG-1250] Defender 2.0, Ethers v6 migration #333
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function getData( | ||
| string[] calldata keys, | ||
| uint256 tokenId | ||
| ) external view override returns (address resolver, address owner, string[] memory values) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
| function _getData( | ||
| string[] calldata keys, | ||
| uint256 tokenId | ||
| ) private view returns (address resolver, address owner, string[] memory values) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
| function getDataByHash( | ||
| uint256[] calldata keyHashes, | ||
| uint256 tokenId | ||
| ) external view override returns (address resolver, address owner, string[] memory keys, string[] memory values) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
| function _getDataByHash( | ||
| uint256[] calldata keyHashes, | ||
| uint256 tokenId | ||
| ) private view returns (address resolver, address owner, string[] memory keys, string[] memory values) { |
Check notice
Code scanning / Slither
Local variable shadowing Low
nickshatilo
force-pushed
the
nickshatilo/REG-1250/defender-2-0-ethers-v6
branch
4 times, most recently
from
5e2d554 to
5185726
Compare
nickshatilo
force-pushed
the
nickshatilo/REG-1250/defender-2-0-ethers-v6
branch
from
5185726 to
d91ccc3
Compare
nickshatilo
force-pushed
the
nickshatilo/REG-1250/defender-2-0-ethers-v6
branch
from
d91ccc3 to
62fea31
Compare
Contracts size report
|
There was a problem hiding this comment.
This is huge! Great job! I'll have another look tomorrow, but looks great to me so far!
@nickshatilo
Contracts size report
|
PR Checklist
1. Contracts versioning
patchversion of the contracts is increased if changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts.minorversion of the contracts is increased if breaking changes have been made to theUNSRegistry,MintingManager,ProxyReader,ENSCustodycontracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.jsonis increased if changes have been made to the config.ens-config.jsonis increased if changes have been made to the config.resolver-keys.jsonis increased if changes have been made to the config.ens-resolver-keys.jsonis increased if changes have been made to the config.5. Package versioning
patchversion of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minorversion of package is synced with version ofUNSRegistrycontract.CHANGELOGis updated with short description for the new version.6. Code review
resolver-keys.jsoncode review is required from DevTools teamens-resolver-keys.jsoncode review is required from DevTools team