Skip to content

Commit

Permalink
reporter/sentry: Add error_types extra
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexisMontagne committed Aug 14, 2024
1 parent 785f15d commit b4056a4
Show file tree
Hide file tree
Showing 2 changed files with 46 additions and 3 deletions.
20 changes: 20 additions & 0 deletions reporter/sentry/reporter.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,21 @@ func (r *Reporter) appendTag(k string, v interface{}, evt *sentry.Event) {
evt.Extra[k] = v
}

func buildErrorTypeChain(err error) []string {
var res []string

for err != nil {
res = append(res, fmt.Sprintf("%T", err))
err = base.UnwrapOnce(err)
}

if len(res) < 2 {
return nil
}

return res
}

func (r *Reporter) buildEvent(err error, opts reporter.ReportOptions) *sentry.Event {
if err == nil {
return nil
Expand All @@ -107,6 +122,7 @@ func (r *Reporter) buildEvent(err error, opts reporter.ReportOptions) *sentry.Ev

evt := sentry.NewEvent()

evt.Level = sentry.LevelError
evt.Timestamp = time.Now()
evt.Message = err.Error()
evt.Transaction = transactionName(ts)
Expand All @@ -128,6 +144,10 @@ func (r *Reporter) buildEvent(err error, opts reporter.ReportOptions) *sentry.Ev
r.appendTag(k, v, evt)
}

if ts := buildErrorTypeChain(err); len(ts) > 0 {
r.appendTag("error_types", ts, evt)
}

return evt
}

Expand Down
29 changes: 26 additions & 3 deletions reporter/sentry/reporter_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,15 @@ func TestBuildEvent(t *testing.T) {
map[string]interface{}{"foo": "bar", "biz": "buz"},
),
evtfn: func(t *testing.T, evt *sentry.Event) {
assert.Equal(t, evt.Extra, map[string]interface{}{"foo": "bar", "biz": "buz"})
assert.Equal(
t,
evt.Extra,
map[string]interface{}{
"foo": "bar",
"biz": "buz",
"error_types": []string{"*stacktrace.withFrame", "*tags.withTags", "*opaque.opaqueError"},
},
)
assert.Equal(t, evt.Tags, map[string]string{"domain": "github.com/upfluence/errors/reporter/sentry"})
},
},
Expand All @@ -120,7 +128,15 @@ func TestBuildEvent(t *testing.T) {
map[string]interface{}{"foo": "bar", "biz": "buz"},
),
evtfn: func(t *testing.T, evt *sentry.Event) {
assert.Equal(t, evt.Extra, map[string]interface{}{"foo": "bar", "biz": "buz"})
assert.Equal(
t,
evt.Extra,
map[string]interface{}{
"foo": "bar",
"biz": "buz",
"error_types": []string{"*stacktrace.withFrame", "*tags.withTags", "*opaque.opaqueError"},
},
)
assert.Equal(t, evt.Tags, map[string]string{"domain": "github.com/upfluence/errors/reporter/sentry"})
},
},
Expand All @@ -136,7 +152,14 @@ func TestBuildEvent(t *testing.T) {
},
},
evtfn: func(t *testing.T, evt *sentry.Event) {
assert.Equal(t, evt.Extra, map[string]interface{}{"biz": "buz"})
assert.Equal(
t,
evt.Extra,
map[string]interface{}{
"biz": "buz",
"error_types": []string{"*stacktrace.withFrame", "*tags.withTags", "*opaque.opaqueError"},
},
)
assert.Equal(t, evt.Tags, map[string]string{"foo": "bar", "domain": "github.com/upfluence/errors/reporter/sentry"})
},
},
Expand Down

0 comments on commit b4056a4

Please sign in to comment.