Make packages/desktop compilable
#7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulpenkiste
changed the title
packages/desktop compilablepackages/desktop compilable
catuhana
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Rust Style Guide recommends using spaces instead of tabs. Also this change only converts spaces to tabs on VSCode, rustfmt.toml file should be used instead.
I disagree with the rust styleguide. Also, that change for vscode only was on purpose as vscode was overriding to the project default (2 wide spaces) |
Rexogamer
previously requested changes
Dec 17, 2024
Rexogamer
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It never actually worked for me so I made it work.
TODO