Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Tweaks #12

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Footer Tweaks #12

wants to merge 4 commits into from

Conversation

lo2dev
Copy link

@lo2dev lo2dev commented Mar 1, 2025

Makes the layout a bit more even by placing the links on the right and also increases the padding a little :3

Not sure about the credits tho. Gonna have to remember my css knowledge to make it look nice on narrow sizes

Screenshot From 2025-03-01 17-17-36

Screenshot From 2025-03-01 17-17-53

@lo2dev lo2dev requested a review from Rexogamer March 1, 2025 15:21
@Rexogamer
Copy link
Member

looks pretty good, but I'm just wondering how this looks with the third column/all the links uncommented?

@lo2dev
Copy link
Author

lo2dev commented Mar 2, 2025

on wide sizes? pretty standard.
on narrow, the columns automatically become single rows

tho the "Stuff" section should probably be broken down into smaller groups and maybe reduce the size of the fonts overall, but that could be another PR

Screenshot From 2025-03-02 11-14-22

Screenshot From 2025-03-02 11-14-46

@Rexogamer
Copy link
Member

this is definitely making me think we should also reduce the fediverse link to just "Fediverse" (or maybe "Fediverse (Mastodon)" for recognisability?), but that's beside the point. I do also wonder if, in the wider view, there should be a bit more padding between the columns and the credits? I'll test this PR locally and think about this

</section>
<!-- TODO: ditto
<section class="column">
<h2>Legalese</h2>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo this should become "Legal". it's shorter :fefe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on one hand "Legal" on its own is maybe a tiny bit boring?
on the other hand, True...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants