Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main page tweaks #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Main page tweaks #6

wants to merge 3 commits into from

Conversation

lo2dev
Copy link

@lo2dev lo2dev commented Feb 12, 2025

There is still some responsive work to be done, like the space between the hero logo and h1 at narrow sizes.

Ideally we should come up with a way to make the fonts and all scale automatically based on the window size instead of @media's.

I also plan to animate the wide logo and also give it some color

image

@lo2dev lo2dev changed the title WIP: main page tweaks Draft: main page tweaks Feb 12, 2025
@lo2dev lo2dev marked this pull request as draft February 12, 2025 09:44
Also make the narrow logo a bit smaller as it's tricky to resize it properly for some reason
And rename and add proper classes to some divs
@lo2dev lo2dev changed the title Draft: main page tweaks Main page tweaks Feb 21, 2025
@lo2dev lo2dev marked this pull request as ready for review February 21, 2025 11:27
@lo2dev lo2dev requested a review from Rexogamer February 21, 2025 11:27
@lo2dev
Copy link
Author

lo2dev commented Feb 21, 2025

updated screenshot:

image

@Rexogamer
Copy link
Member

not entirely sure how I feel about the logo being there. the space was for a screenshot of the app, right? the logo seems a bit bare/duplicative, so I'm not sure if we should just leave it empty until we have a screenshot or if maybe we should add something with the logo? 🤔

@lo2dev
Copy link
Author

lo2dev commented Feb 22, 2025

It's pretty empty without anything on the right side.

What i had in mind is that we use the logo until the frontend is in a good enough shape to present, but i forgot to mention that lol.

I could create a skeleton mockup in inkscape until we have a good enough screenshot

@Rexogamer
Copy link
Member

I think that would be a good idea :3

@amycatgirl amycatgirl added kind/pages New page request, page tweaks, etc... kind/branding Issue/PR related to our brand (colours, logo, wording, fonts, etc...) labels Feb 23, 2025
Copy link
Member

@amycatgirl amycatgirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM so far. I would personally wait until we have some sort of screenshot of the client or a skeleton of the client before merging, as having the logo in the hero section looks weird (imo).

@lo2dev
Copy link
Author

lo2dev commented Feb 24, 2025

Is it fine if I remove the logo for now, merge this and do a skeleton svg later on? I kinda want to get this merged so i can work on the other PRs :3

@catuhana
Copy link
Contributor

You can create a branch off of this to work on other stuff that depends on this. GitHub can automatically detect that the new branch depends on this one, and it would do the proper merging. https://stackoverflow.com/a/70178279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/branding Issue/PR related to our brand (colours, logo, wording, fonts, etc...) kind/pages New page request, page tweaks, etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants