Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphcache): add logger interface #3444

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

JoviDeCroock
Copy link
Collaborator

Resolves #3404

Summary

This adds an option to the graphCache constructor named Logger we will use the logger to convey information that is encountered during development. In doing so a user can choose to remove the warnings by stubbing the logger with () => {} or adding other custom logic to filter things out.

Set of changes

  • add Logger interface for graph-cache

@JoviDeCroock JoviDeCroock requested a review from kitten December 2, 2023 10:26
Copy link

changeset-bot bot commented Dec 2, 2023

🦋 Changeset detected

Latest commit: db6a6be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoviDeCroock JoviDeCroock merged commit 1fee86f into urql-graphql:main Dec 2, 2023
This was referenced Dec 1, 2023
@johnpmitsch
Copy link

Thank you for this! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Option to hide warnings when in development
3 participants