Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rn-storage): Update outdated React Native dependencies #3485

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

albinhubsch
Copy link
Contributor

Update outdated React Native peer reqs

Summary

Currently @urql/storage-rn is breaking the update process to Expo version 50 due to the set peer dependencies in this package. In Expo 50 they bumped RN Netinfo to v11.

Set of changes

  • Updated React Native NetInfo package to version 11 and upped the peer reqs in package.json
  • Updated React Native Async Storage to 1.21 and upped the peer reqs in package.json

Update outdated peer reqs
Copy link

changeset-bot bot commented Jan 22, 2024

🦋 Changeset detected

Latest commit: d3c19b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/storage-rn Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a changeset, needs an update to the lockfile and remark on an unexpected peer bump

@kitten kitten changed the title Update outdated React Native dependencies in package.json chore(rn-storage): Update outdated React Native dependencies Jan 22, 2024
@albinhubsch
Copy link
Contributor Author

needs a changeset, needs an update to the lockfile and remark on an unexpected peer bump

Should be fixed :)

Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Copy link
Member

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi, I'll apply the change to the changeset to move this PR along and will get it merged

.changeset/strange-drinks-sip.md Outdated Show resolved Hide resolved
@albinhubsch
Copy link
Contributor Author

Just fyi, I'll apply the change to the changeset to move this PR along and will get it merged

Thanks for the super fast response on this issue!

@kitten kitten merged commit 7f451f9 into urql-graphql:main Jan 22, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants