Treat empty groups response from Keycloak as an error #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlx
changed the title
Also add failing test for empty groups returning an error.
There are cases where insufficient permissions for some Keycloak API endpoints will not return an error, but will instead return a "successful" empty response. Handle this case for Keycloak groups by treating an empty response as an error.
smlx
force-pushed
the
safer-empty-groups
branch
from
af852fe to
16755ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where insufficient permissions for some Keycloak API
endpoints will not return an error, but will instead return a
"successful" empty response.
Handle this case for Keycloak groups by treating an empty response as an
error.
Closes: #149
Closes: #150