Tony changes to basicsubs, updated viscosity for Sr, NH4, and tidied … #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If these all look okay I'll merge it: https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508 |
|
I think the diffs are okay, so go ahead and merge.
…On Tue, Mar 11, 2025 at 7:04 PM Charlton, Scott R. ***@***.***> wrote:
If these all look okay I'll merge it:
https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
—
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: scharlton2]*scharlton2* left a comment (usgs-coupled/phreeqc3#93)
<#93 (comment)>
If these all look okay I'll merge it:
https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
—
Reply to this email directly, view it on GitHub
<#93 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Tony found a couple more errors in the databases. I think all is correct
now in mix_error.
On Tue, Mar 11, 2025 at 8:57 PM David Parkhurst ***@***.***>
wrote:
… I think the diffs are okay, so go ahead and merge.
On Tue, Mar 11, 2025 at 7:04 PM Charlton, Scott R. <
***@***.***> wrote:
> If these all look okay I'll merge it:
>
> https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
>
> —
> Reply to this email directly, view it on GitHub
> <#93 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
> [image: scharlton2]*scharlton2* left a comment (usgs-coupled/phreeqc3#93)
> <#93 (comment)>
>
> If these all look okay I'll merge it:
>
> https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
>
> —
> Reply to this email directly, view it on GitHub
> <#93 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Let's merge, but I think we should wait a while to put out new versions.
Something else may pop up.
David
On Wed, Mar 12, 2025 at 3:06 AM David Parkhurst ***@***.***>
wrote:
… Tony found a couple more errors in the databases. I think all is correct
now in mix_error.
On Tue, Mar 11, 2025 at 8:57 PM David Parkhurst ***@***.***>
wrote:
> I think the diffs are okay, so go ahead and merge.
>
> On Tue, Mar 11, 2025 at 7:04 PM Charlton, Scott R. <
> ***@***.***> wrote:
>
>> If these all look okay I'll merge it:
>>
>> https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#93 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>> [image: scharlton2]*scharlton2* left a comment
>> (usgs-coupled/phreeqc3#93)
>> <#93 (comment)>
>>
>> If these all look okay I'll merge it:
>>
>> https://my.cdash.org/viewTest.php?onlyfailed&buildid=2851508
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#93 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/APZJL5ZJ4FI4BJYHIYZLH4D2T6BYPAVCNFSM6AAAAABY2EZNEGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJWGEYDQMJXGU>
>> .
>> You are receiving this because you authored the thread.Message ID:
>> ***@***.***>
>>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…databases.
Here are Tony's latest changes as of Mar 11, 2025.