Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-4 Account page. #12

Merged
merged 7 commits into from
Feb 4, 2025
Merged

SC-4 Account page. #12

merged 7 commits into from
Feb 4, 2025

Conversation

JoshuaWuebbolt
Copy link
Collaborator

Created an account page and added a pie-chart component which can be passed a list of names and list of numbers to create a pie chart with.

VamsiGajjela
VamsiGajjela approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@VamsiGajjela VamsiGajjela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i am curious why changing the value from 10->5 ended up needing so many changes though. Ty for fixing that up regardless!

@VamsiGajjela
Copy link
Collaborator

Oh also your CI is failing so just try to fix that up, seems like a linter issue

@JoshuaWuebbolt JoshuaWuebbolt merged commit 6736959 into main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VamsiGajjela VamsiGajjela VamsiGajjela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaWuebbolt @VamsiGajjela