Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCRUM-3] Implement login page ui #1

Merged
merged 2 commits into from
Jan 30, 2025
Merged

[SCRUM-3] Implement login page ui #1

merged 2 commits into from
Jan 30, 2025

Conversation

ziadzananiri
Copy link
Collaborator

@ziadzananiri ziadzananiri commented Jan 30, 2025

The main.dart file was also rewritten to handle GoRoute requests and root-level widget handling.

@ziadzananiri ziadzananiri added the enhancement New feature or request label Jan 30, 2025
@ziadzananiri ziadzananiri requested a review from V-X-L-U January 30, 2025 00:01
@ziadzananiri ziadzananiri self-assigned this Jan 30, 2025
Copy link
Collaborator

@V-X-L-U V-X-L-U left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good and you were able to complete it pretty quickly! I'm glad you were able to find useful packages like the GoRouter. The most major comment would be on dealing with the general nested-ness of Flutter code and the typical remedies.

frontend/lib/main.dart Outdated Show resolved Hide resolved
frontend/lib/main.dart Outdated Show resolved Hide resolved
frontend/lib/views/login.dart Outdated Show resolved Hide resolved
frontend/lib/views/login.dart Show resolved Hide resolved
frontend/lib/views/login.dart Outdated Show resolved Hide resolved
… styling, page routing, and login page. Login page rewritten for readability.
@ziadzananiri ziadzananiri requested a review from V-X-L-U January 30, 2025 22:36
@ziadzananiri ziadzananiri dismissed V-X-L-U’s stale review January 30, 2025 22:37

Applied suggested changes in new commit

@ziadzananiri ziadzananiri added the documentation Improvements or additions to documentation label Jan 30, 2025
child: Text('Forgot Password?'),
);

return SafeArea(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done refactor, this will help us quickly identify specific sub-widgets and consider their layout separately as our pages and widgets get more complex.

@V-X-L-U V-X-L-U merged commit a430d8c into main Jan 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants