-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCRUM-3] Implement login page ui #1
Conversation
…ears on start up of application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good and you were able to complete it pretty quickly! I'm glad you were able to find useful packages like the GoRouter. The most major comment would be on dealing with the general nested-ness of Flutter code and the typical remedies.
… styling, page routing, and login page. Login page rewritten for readability.
Applied suggested changes in new commit
child: Text('Forgot Password?'), | ||
); | ||
|
||
return SafeArea( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done refactor, this will help us quickly identify specific sub-widgets and consider their layout separately as our pages and widgets get more complex.
The main.dart file was also rewritten to handle GoRoute requests and root-level widget handling.