-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise Backend with Certain Dedicated Features #47
Conversation
Something that was not discussed before is the structure of the endpoints... Here is what I have decided
Be aware @uwasystemhealth/redbacks... this is important to know for both a backend and frontend... Please feel free to question any of these if it doesnt make sense... If later on in the future, the endpoint becomes too big for
we can open up endpoints like
|
I'll be merging this with or without a review by tomorrow to progress more tickets that have dependency on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just remove the unuse comment for now
const Reviewer: NextPage = () => { | ||
|
||
const [showArchived, setShowArchived] = useState(false); | ||
const archivedButtonText = showArchived ? "Hide Archived" : "Show Archvied"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have not checked the review page as much (frontend)... I'll continue it in the #14 issue... However, for now, I don't think we'll implement archiving simply because we don't have it as part of the #36 .
This is not really a problem though because archiving (as a feature) only is needed for when there is too much course evaluation assigned to a particular user. Realistically speaking, this will only grow by atmost 4 course evaluation per year for a user. (need to check with @mhodki), but as part of MVP, it is not required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
|
||
useEffect(() => { | ||
const loadedReviews = getCourseEvaluations(); | ||
const reviewPro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn... i didnt notice this broke the build... i really need the #50 to start doing builds alone
Change Summary
- CourseEvaluationJustification
- Documents
- Review
- ReviewEocSpecific
- ReviewDocument
- initial permission for a reviewer
- permission that can be applied to anything that has
course_evaluation
attribute (seeCourseEvaluationIsCoordinatorAllowAllViaObjectReference
)Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
This has a lot of changes... and it is going so much... I need to split this changes now
The things that have been completed as a feature are:
The things that are not complete:
Flush Database
You will need to flush your database here, as I have done a lot of not reverse incompatible migrations