[oneMath][RNG] Add geometric distribution to Device API #604
Conversation
| @@ -78,6 +78,10 @@ basic random number generators. | |||
| - integer | |||
| - integer | |||
| - Bernoulli distribution | |||
| * - :ref:`onemath_device_rng_geometric` | |||
| - integer | |||
| - float | |||
There was a problem hiding this comment.
double-checking: is it float for both int32_t/int64_t or should it be float/double ?
There was a problem hiding this comment.
You are correct, int64_t can be mapped to double in terms of type.
Here, as an idea, float refers to general floating-point data type, not exact float type.
The same is done for discrete uniform distr and integer type in general in this table.
Please share if you think it make sense to reformat this table
There was a problem hiding this comment.
hmmm, in the table with Continuous distributions it states float/double separately. Probably it makes sense to change float to floating point and add a note that it can vary for distributions implementation depending on the integer data type size
There was a problem hiding this comment.
Applied. @aelizaro please take a look one more time :)
iMartyan
changed the title
iMartyan
force-pushed
the
add_rng_geometric_engines
branch
from
1a5f644 to
7d33e6f
Compare
Proposal to add geometric distribution to oneMath RNG Device API.
Overview: API similar to existing Bernoulli distribution. Supported data types: 32 and 64 integer types.
fix: changed notes style for RNG