Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix on mirror leap repositories #1786

Closed
wants to merge 2 commits into from
Closed

Temporary fix on mirror leap repositories #1786

wants to merge 2 commits into from

Conversation

szachovy
Copy link
Contributor

@szachovy szachovy commented Mar 5, 2025 •
edited
Loading

What does this PR change?

Pipelines are failing due to mirror repository renaming:

Screenshot from 2025-03-05 11-14-52

The following repositories are affected:

10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [backports_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/backports/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [backports_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/backports/] Repository type can't be determined.
10:30:59  
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [os_pool_repo|http://minima-mirror-ci-bv.mgr.suse.de/distribution/leap/15.5/repo/oss/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [os_pool_repo|http://minima-mirror-ci-bv.mgr.suse.de/distribution/leap/15.5/repo/oss/] Repository type can't be determined.
10:30:59  
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [os_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/oss/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [os_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/oss/] Repository type can't be determined.
10:30:59  
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Some of the repositories have not been refreshed because of an error.
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [ERROR   ] retcode: 4
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [ERROR   ] An error was encountered while installing package(s): Zypper command failure: Running scope as unit: run-r27d48f2b87ff4f4ba5f75eb7189c0f93.scope
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [backports_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/backports/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [backports_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/backports/] Repository type can't be determined.
10:30:59  
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [os_pool_repo|http://minima-mirror-ci-bv.mgr.suse.de/distribution/leap/15.5/repo/oss/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [os_pool_repo|http://minima-mirror-ci-bv.mgr.suse.de/distribution/leap/15.5/repo/oss/] Repository type can't be determined.
10:30:59  
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): Error building the cache:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): [os_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/oss/] Valid metadata not found at specified URL
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec): History:
10:30:59  cucumber_testsuite.suse_minion.provisioning[0] (remote-exec):  - [os_update_repo|http://minima-mirror-ci-bv.mgr.suse.de/update/leap/15.5/oss/] Repository type can't be determined.

Seems like someone is doing some operations now, so I am not retriggering highstate on the mirror:

Screenshot from 2025-03-05 11-19-41

@szachovy szachovy self-assigned this Mar 5, 2025
@szachovy szachovy requested a review from a team as a code owner March 5, 2025 10:19
nodeg
nodeg requested changes Mar 5, 2025
View reviewed changes
salt/repos/os.sls
- baseurl: http://download.opensuse.org/update/leap/{{ grains['osrelease'] }}/oss/
- refresh: True

{% if grains['osrelease_info'][0] == 15 and grains['osrelease_info'][1] >= 3 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests are failing with a syntax error:

jinja2.exceptions.TemplateSyntaxError: Unexpected end of template. Jinja was looking for the following tags: 'elif' or 'else' or 'endif'. The innermost block that needs to be closed is 'if'.

You opened 2 ifs, but closed only one and are missing a second %{ endif }.

srbarrios
srbarrios reviewed Mar 5, 2025
View reviewed changes
backend_modules/libvirt/host/combustion
@@ -69,8 +69,8 @@ zypper ar http://${ use_mirror_images ? mirror : "download.opensuse.org" }/repos
zypper ar http://${ use_mirror_images ? mirror : "download.opensuse.org" }/repositories/systemsmanagement:/Uyuni:/Test-Packages:/Pool/rpm/ test_repo_rpm_pool

# Leap repos are required to install expect
zypper ar http://${ use_mirror_images ? mirror : "download.opensuse.org" }/distribution/leap/15.5/repo/oss/ leap_pool_repo
zypper ar http://${ use_mirror_images ? mirror : "download.opensuse.org" }/update/leap/15.5/oss/ leap_update_repo
zypper ar http://${ use_mirror_images ? mirror : "download.opensuse.org" }/distribution/leap/15.5/repo/${ use_mirror_images ? "oss-old" : "oss" }/ leap_pool_repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's what we officially have on the origin:
image

What's the reason behind that hack made on the mirror, and this rename?
I would avoid that hack we made on the mirror... take into account that people can be using their own mirror instance to deploy sumaform, and that hack will not be in place.

@Bischoff Bischoff self-requested a review March 5, 2025 11:02
Bischoff
Bischoff reviewed Mar 5, 2025
View reviewed changes
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said during the standup, rather than modifying sumaform, even temporarily, I would just trigger minima again on the mirrors.

@szachovy
Copy link
Contributor Author

szachovy commented Mar 6, 2025

Closing as most problems with mirror are solved now.

@szachovy szachovy closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bischoff Bischoff Bischoff left review comments

@srbarrios srbarrios srbarrios left review comments

@nodeg nodeg nodeg requested changes

Assignees

@szachovy szachovy

Labels
bug tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szachovy @Bischoff @srbarrios @nodeg