Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLES 15 SP6 as base OS for SUSE Manager 5.0 #1787

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Mar 6, 2025

What does this PR change?

Add SLES 15 SP6 as base OS for SUSE Manager 5.0

Links

See https://github.com/SUSE/spacewalk/pull/26622

@Bischoff Bischoff requested a review from a team as a code owner March 6, 2025 11:57
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we differentiate between base OS to use? These grains are not enough, they are the same for both. Don't we need a new grain to know when to deploy each one?

Also the repos are supposed to be for 15sp6, right?

%{ if product_version == "5.0-released" }
- id: container_tools_repo
name: container_tools_repo
baseurl: http://${ use_mirror_images ? mirror : "download.suse.de/ibs" }/SUSE:/SLE-15-SP5:/Update:/Products:/Manager50/images/repo/SUSE-Manager-Server-5.0-POOL-x86_64-Media1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is 15sp5, don't we need 15sp6?

Copy link
Contributor Author

@Bischoff Bischoff Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, it looks correct:

SUSE Manager 5.0 was published on top of SLE Micro 5.5, and SLE micro 5.5 tools were stored in the SLE 15.5 repository.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you double checked with releng?

%{ if product_version == "5.0-released" }
- id: container_tools_repo
name: container_tools_repo
baseurl: http://${ use_mirror_images ? mirror : "download.suse.de/ibs" }/SUSE:/SLE-15-SP5:/Update:/Products:/Manager50/images/repo/SUSE-Manager-Proxy-5.0-POOL-x86_64-Media1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same 15sp6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, no, for the convoluted reason explained above.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, let's be sure, by confirming with releng please

@Bischoff Bischoff requested a review from ktsamis March 6, 2025 15:31
@Bischoff
Copy link
Contributor Author

Bischoff commented Mar 6, 2025

How do we differentiate between base OS to use? These grains are not enough, they are the same for both. Don't we need a new grain to know when to deploy each one?

We don't use a dedicated grain.

The magic is in this line of env.rb:

$is_transactional_server = transactional_system? 'server'

Also the repos are supposed to be for 15sp6, right?

Right, but see my explanation for the 5.0-released tools.

@Bischoff Bischoff merged commit a8714e3 into uyuni-project:master Mar 8, 2025
2 checks passed
@Bischoff Bischoff deleted the baseos-sles15sp6 branch March 8, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants