-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SLES 15 SP6 as base OS for SUSE Manager 5.0 #1787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we differentiate between base OS to use? These grains are not enough, they are the same for both. Don't we need a new grain to know when to deploy each one?
Also the repos are supposed to be for 15sp6, right?
%{ if product_version == "5.0-released" } | ||
- id: container_tools_repo | ||
name: container_tools_repo | ||
baseurl: http://${ use_mirror_images ? mirror : "download.suse.de/ibs" }/SUSE:/SLE-15-SP5:/Update:/Products:/Manager50/images/repo/SUSE-Manager-Server-5.0-POOL-x86_64-Media1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is 15sp5, don't we need 15sp6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, it looks correct:
SUSE Manager 5.0 was published on top of SLE Micro 5.5, and SLE micro 5.5 tools were stored in the SLE 15.5 repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you double checked with releng?
%{ if product_version == "5.0-released" } | ||
- id: container_tools_repo | ||
name: container_tools_repo | ||
baseurl: http://${ use_mirror_images ? mirror : "download.suse.de/ibs" }/SUSE:/SLE-15-SP5:/Update:/Products:/Manager50/images/repo/SUSE-Manager-Proxy-5.0-POOL-x86_64-Media1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same 15sp6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, no, for the convoluted reason explained above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, let's be sure, by confirming with releng please
We don't use a dedicated grain. The magic is in this line of
Right, but see my explanation for the 5.0-released tools. |
What does this PR change?
Add SLES 15 SP6 as base OS for SUSE Manager 5.0
Links
See https://github.com/SUSE/spacewalk/pull/26622