Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test for spring impersonate #20938

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

caalador
Copy link
Contributor

Add a test that validates that
spring impersonate works as expected.

part of #20495

Add a test that validates that
spring impersonate works as expected.
Copy link

github-actions bot commented Jan 31, 2025

Test Results

1 165 files  ±0  1 165 suites  ±0   1h 34m 48s ⏱️ - 4m 15s
7 638 tests +5  7 581 ✅ +4  57 💤 +1  0 ❌ ±0 
7 961 runs   - 2  7 895 ✅  - 5  66 💤 +3  0 ❌ ±0 

Results for commit fd70fdf. ± Comparison against base commit 4b321c7.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment removal and a potential improvement (but feel free to ignore), other than that looks good

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Jan 31, 2025
@vaadin-bot vaadin-bot added +0.0.1 and removed +1.0.0 labels Jan 31, 2025
skip test for urlmapping
Copy link

sonarqubecloud bot commented Feb 3, 2025

@caalador caalador requested a review from mcollovati February 3, 2025 07:20
@mcollovati mcollovati merged commit f5c972a into main Feb 3, 2025
26 checks passed
@mcollovati mcollovati deleted the issues/20495-impersonate branch February 3, 2025 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants