fix: restore scroll position when virtualizer host is connected #8642
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
reviewed
Feb 5, 2025
web-padawan
force-pushed
the
fix/virtualizer-preserve-scroll-position
branch
from
2872a35 to
0fb7bb7
Compare
web-padawan
changed the title
web-padawan
force-pushed
the
fix/virtualizer-preserve-scroll-position
branch
from
324e4ad to
0fb7bb7
Compare
|
sissbruecker
approved these changes
Feb 11, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 11, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8630
Related to #6431 (comment)
When an element using virtualizer (e.g. virtual-list or grid) is used in dialog or other overlay, it is moved within DOM while also changing visibility. Added
ResizeObserverto handle this case and restorescrollTop, which gets reset whenever the element gets disconnected from the DOM. This fixes the problem of empty items after dialog reopening.Type of change