Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allFuturesThrowing compilation issue on daily #1026

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

diegomrsantos
Copy link
Contributor

This fixes allFuturesThrowing that is failing with a compilation issue on daily after chronos new release.

@diegomrsantos diegomrsantos changed the title fix allFuturesThrowing compilation issue on daily fix: allFuturesThrowing compilation issue on daily Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe4ff79) 83.28% compared to head (208feb9) 83.25%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           unstable    #1026      +/-   ##
============================================
- Coverage     83.28%   83.25%   -0.04%     
============================================
  Files            91       91              
  Lines         15442    15442              
============================================
- Hits          12861    12856       -5     
- Misses         2581     2586       +5     
Files Coverage Δ
libp2p/errors.nim 84.21% <100.00%> (ø)

... and 3 files with indirect coverage changes

@diegomrsantos diegomrsantos merged commit 7faa0fa into unstable Feb 19, 2024
22 of 26 checks passed
@diegomrsantos diegomrsantos deleted the fix-compilation-issue-daily branch February 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

2 participants