Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make spans inline #1

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

BlueGlassBlock
Copy link
Member

No description provided.

@WRXinYue
Copy link
Member

WRXinYue commented Aug 22, 2024

I believe this PR is correct, but there are some details that need to be emphasized.

For example, according to the W3C HTML5 specification and Chrome default styles, the default value of the display property for certain HTML tags, such as span, is not explicitly listed. According to the CSS Display specification, the initial value of display is inline. Therefore, here is a more intuitive list of default display property values for HTML tags:

display HTML Tags
block div, p, h1, h2, h3, h4, h5, h6, ul, ol, form, option, main, header, footer, section, nav, article, aside, body, html
inline a, span, img, iframe, video, label, br
inline-block input, textarea, select
list-item li
table table
table-row-group tbody
table-row tr
table-cell td, th
none head, style, script, meta, title, link

Regarding browser style resets: currently, the only pure CSS method is to manually look up and set the browser's default values.

@YunYouJun Do we need to further expand on other HTML tag css-i18n?

@YunYouJun YunYouJun merged commit f7f10b5 into valaxyjs:main Aug 23, 2024
2 checks passed
Copy link

Yun Good!

@YunYouJun
Copy link
Member

We can expand it when we need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants