Skip to content

Commit

Permalink
Add TRUST result (#76)
Browse files Browse the repository at this point in the history
  • Loading branch information
D-Baykov authored Oct 21, 2024
1 parent 33dff99 commit 411bd4d
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
<management.port>8023</management.port>
<exposed.ports>${server.port} ${management.port}</exposed.ports>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<fraudo.version>1.0.6</fraudo.version>
<fraudo.version>1.0.7</fraudo.version>
<clickhouse-jdbc.version>0.3.1</clickhouse-jdbc.version>
<fraudbusters-proto.version>1.111-913e879</fraudbusters-proto.version>
<fraudbusters-proto.version>1.112-e9d16e0</fraudbusters-proto.version>
<trusted.tokens.proto.version>1.7-6d29f86</trusted.tokens.proto.version>
<wb.list.proto.version>1.44-5dbd6d4</wb.list.proto.version>
<dgraph4j.version>21.12.0</dgraph4j.version>
Expand Down Expand Up @@ -109,7 +109,7 @@
<dependency>
<groupId>dev.vality</groupId>
<artifactId>damsel</artifactId>
<version>1.623-f8e56c6</version>
<version>1.648-ad715bd</version>
</dependency>
<dependency>
<groupId>dev.vality.woody</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ public class CheckedResultToRiskScoreConverter implements Converter<CheckedResul
@Override
public RiskScore convert(CheckedResultModel checkedResultModel) {
return switch (checkedResultModel.getResultModel().getResultStatus()) {
case TRUST -> RiskScore.trusted;
case ACCEPT, ACCEPT_AND_NOTIFY, NOTIFY -> RiskScore.low;
case DECLINE, DECLINE_AND_NOTIFY -> RiskScore.fatal;
default -> RiskScore.high;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ public class ResultStatusConverter implements Converter<ResultStatus, dev.vality
public dev.vality.damsel.fraudbusters.ResultStatus convert(ResultStatus resultStatus) {
var status = new dev.vality.damsel.fraudbusters.ResultStatus();
switch (resultStatus) {
case TRUST -> status.setTrust(new Trust());
case ACCEPT -> status.setAccept(new Accept());
case ACCEPT_AND_NOTIFY -> status.setAcceptAndNotify(new AcceptAndNotify());
case THREE_DS -> status.setThreeDs(new ThreeDs());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,24 @@ void applyOneRuleOnlyRuleNotTriggered() {
assertEquals(new ArrayList<>(), firstCheckedResult.getResultModel().getNotificationsRule());
}

@Test
void applyTrustRule() {
PaymentModel firstTransaction = TestObjectsFactory.createPaymentModel(25L);
String firstTransactionId = UUID.randomUUID().toString();
String ruleTemplate = "rule: amount() > 1 -> trust;";
Map<String, CheckedResultModel> result = ruleTestingService.checkSingleRule(
Map.of(firstTransactionId, firstTransaction),
ruleTemplate
);

assertEquals(1, result.size());
CheckedResultModel firstCheckedResult = result.get(firstTransactionId);
assertEquals(ruleTemplate, firstCheckedResult.getCheckedTemplate());
assertEquals(ResultStatus.TRUST, firstCheckedResult.getResultModel().getResultStatus());
assertNotNull(firstCheckedResult.getResultModel().getRuleChecked());
assertEquals(new ArrayList<>(), firstCheckedResult.getResultModel().getNotificationsRule());
}

@Test
void applyRuleWithinRulesetNoTimestampDifferentPartyShop() {
// single templates
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,11 @@ void convertNotify() {
status.setNotify(new Notify());
assertEquals(status, converter.convert(ResultStatus.NOTIFY));
}

@Test
void convertTrusted() {
var status = new dev.vality.damsel.fraudbusters.ResultStatus();
status.setTrust(new Trust());
assertEquals(status, converter.convert(ResultStatus.TRUST));
}
}

0 comments on commit 411bd4d

Please sign in to comment.