Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Push images to GitHub Container Registry #53

Open
wants to merge 3 commits into
base: mainline
Choose a base branch
from

Conversation

bjw-s
Copy link

@bjw-s bjw-s commented Feb 26, 2025

This PR should add support for pushing container images to GitHub Container Registry under the valkey-io organization.

The resulting images will be tagged as ghcr.io/valkey-io/valkey:<tag>

List of tags that will be created
  • ghcr.io/valkey-io/valkey:unstable
  • ghcr.io/valkey-io/valkey:unstable-bookworm
  • ghcr.io/valkey-io/valkey:unstable-alpine
  • ghcr.io/valkey-io/valkey:unstable-alpine3.21
  • ghcr.io/valkey-io/valkey:8.0.2
  • ghcr.io/valkey-io/valkey:8.0
  • ghcr.io/valkey-io/valkey:8
  • ghcr.io/valkey-io/valkey:latest
  • ghcr.io/valkey-io/valkey:8.0.2-bookworm
  • ghcr.io/valkey-io/valkey:8.0-bookworm
  • ghcr.io/valkey-io/valkey:8-bookworm
  • ghcr.io/valkey-io/valkey:bookworm
  • ghcr.io/valkey-io/valkey:8.0.2-alpine
  • ghcr.io/valkey-io/valkey:8.0-alpine
  • ghcr.io/valkey-io/valkey:8-alpine
  • ghcr.io/valkey-io/valkey:alpine
  • ghcr.io/valkey-io/valkey:8.0.2-alpine3.21
  • ghcr.io/valkey-io/valkey:8.0-alpine3.21
  • ghcr.io/valkey-io/valkey:8-alpine3.21
  • ghcr.io/valkey-io/valkey:alpine3.21
  • ghcr.io/valkey-io/valkey:8.1.0-rc1
  • ghcr.io/valkey-io/valkey:8.1
  • ghcr.io/valkey-io/valkey:8.1.0-rc1-bookworm
  • ghcr.io/valkey-io/valkey:8.1-bookworm
  • ghcr.io/valkey-io/valkey:8.1.0-rc1-alpine
  • ghcr.io/valkey-io/valkey:8.1-alpine
  • ghcr.io/valkey-io/valkey:8.1.0-rc1-alpine3.21
  • ghcr.io/valkey-io/valkey:8.1-alpine3.21
  • ghcr.io/valkey-io/valkey:7.2.8
  • ghcr.io/valkey-io/valkey:7.2
  • ghcr.io/valkey-io/valkey:7
  • ghcr.io/valkey-io/valkey:7.2.8-bookworm
  • ghcr.io/valkey-io/valkey:7.2-bookworm
  • ghcr.io/valkey-io/valkey:7-bookworm
  • ghcr.io/valkey-io/valkey:7.2.8-alpine
  • ghcr.io/valkey-io/valkey:7.2-alpine
  • ghcr.io/valkey-io/valkey:7-alpine
  • ghcr.io/valkey-io/valkey:7.2.8-alpine3.21
  • ghcr.io/valkey-io/valkey:7.2-alpine3.21
  • ghcr.io/valkey-io/valkey:7-alpine3.21

Partly implements #17

@roshkhatri
Copy link
Member

roshkhatri commented Feb 26, 2025

Does this PR have any pre-requisites setup required from the valkey-io org to publish on ghcr, before we merge this?

@roshkhatri
Copy link
Member

Can you also mention the Tags are getting created by the workflows? and also the results on the GHCR? you can add everything to the top comment.

Thanks!

Signed-off-by: Bernd Schorgers <me@bjw-s.dev>
Signed-off-by: Bernd Schorgers <me@bjw-s.dev>
Signed-off-by: Bernd Schorgers <me@bjw-s.dev>
@bjw-s
Copy link
Author

bjw-s commented Feb 27, 2025

Does this PR have any pre-requisites setup required from the valkey-io org to publish on ghcr, before we merge this?

Everything should be good to go without any changes. The permissions snippet on the build job ensures that the temporary GitHub token is allowed to write content to the GitHub registry.

Can you also mention the Tags are getting created by the workflows? and also the results on the GHCR? you can add everything to the top comment.

Done 👍 I have also added a quick mention to the project README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants