Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for JWTKit v5 #157

Merged
merged 11 commits into from
Oct 5, 2024
Merged

Update for JWTKit v5 #157

merged 11 commits into from
Oct 5, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Oct 5, 2024 •
edited
Loading

  • Updates JWTKit version
  • Adopts swift-format (with lint job)
  • Removes a tests which is no longer needed as we're not calling through to C anymore (and therefore don't really have segfaults)
  • Updates to swift-testing

@ptoffy ptoffy marked this pull request as ready for review October 5, 2024 10:09
@ptoffy ptoffy requested review from 0xTim and gwynne as code owners October 5, 2024 10:09
0xTim
0xTim reviewed Oct 5, 2024
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
@ptoffy ptoffy requested a review from 0xTim October 5, 2024 15:09
0xTim
0xTim requested changes Oct 5, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check in the Swift format config file so people can run it locally

0xTim
0xTim approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we can it to check a parent directory so just need to ensure that when working on Vapor stuff we pull in the correct file

@ptoffy ptoffy enabled auto-merge (squash) October 5, 2024 17:09
@ptoffy ptoffy merged commit f208afc into main Oct 5, 2024
8 checks passed
@ptoffy ptoffy deleted the v5 branch October 5, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

@gwynne gwynne gwynne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptoffy @gwynne @0xTim