Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Key Collections #164

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Updating Key Collections #164

merged 1 commit into from
Jan 7, 2025

Conversation

dimitribouniol
Copy link
Contributor

@dimitribouniol dimitribouniol commented Jan 5, 2025 •
edited by penny-for-vapor bot
Loading

These changes are now available in 5.1.2

JWT key collections (keys) are marked as being settable, but in practice they can't be since jwt is not settable. Marking keys as having a non mutating setting fixes this and allows the underlying storage to be updated safely.

@dimitribouniol dimitribouniol requested a review from ptoffy as a code owner January 5, 2025 20:47
@ptoffy ptoffy added the semver-patch Internal changes only label Jan 7, 2025
ptoffy
ptoffy approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ptoffy ptoffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptoffy ptoffy enabled auto-merge (squash) January 7, 2025 10:07
@ptoffy ptoffy merged commit af1c597 into vapor:main Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptoffy ptoffy ptoffy approved these changes

Assignees
No one assigned
Labels
semver-patch Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitribouniol @ptoffy