feat(xo-6): add sidebar to host networks view #8287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3bastianCZ
force-pushed
the
host-networks-with-side-bar-
branch
2 times, most recently
from
1190751 to
24b8506
Compare
S3bastianCZ
force-pushed
the
host-networks-with-side-bar-
branch
from
8fecac8 to
fbdcffc
Compare
S3bastianCZ
force-pushed
the
host-networks-with-side-bar-
branch
12 times, most recently
from
7a43728 to
d3d0b57
Compare
S3bastianCZ
force-pushed
the
host-networks-with-side-bar-
branch
from
d3d0b57 to
28df170
Compare
S3bastianCZ
force-pushed
the
host-networks-with-side-bar-
branch
from
28df170 to
6ebe5fb
Compare
OlivierFL
requested changes
Feb 28, 2025
| host: XoHost | ||
| }>() | ||
| const { records } = usePifStore().subscribe() | ||
| const route = useRoute() |
There was a problem hiding this comment.
To fix type-check error l.30:
Suggested change
| const route = useRoute() | |
| const route = useRoute<'/host/[id]'>() |
Comment on lines
+40
to
+41
| - xo-server minor | ||
| - xo-web minor |
There was a problem hiding this comment.
I don't think it is necessary:
Suggested change
| - xo-server minor | |
| - xo-web minor |
Comment on lines
+71
to
+72
| .map(slaveId => baseContext.records.value.find(pif => pif.id === slaveId)) | ||
| .map(pif => pif!.device) |
There was a problem hiding this comment.
Can’t it be simplified?
| </UiComplexIcon> | ||
| <a href="">{{ networkNameLabel }}</a> | ||
| --> | ||
| <span v-tooltip class="text-ellipsis">{{ network?.name_label }}</span> |
There was a problem hiding this comment.
Shouldn't we display at least a - if network is undefined and we have no name_label?
| {{ $t('network') }} | ||
| </template> | ||
| <template #value> | ||
| <div class="network"> |
There was a problem hiding this comment.
The <div> will always be rendered, even if network is undefined
| {{ pif.dns }} | ||
| </span> | ||
| </template> | ||
| <template v-if="pif.dns" #addons> |
There was a problem hiding this comment.
Suggested change
| <template v-if="pif.dns" #addons> | |
| <template #addons> |
| :icon="faCopy" | ||
| size="medium" | ||
| accent="brand" | ||
| @click="copy(String(pif.dns))" |
There was a problem hiding this comment.
Same here for the conversion
Comment on lines
+259
to
+265
| <template v-if="pif.gateway" #addons> | ||
| <UiButtonIcon | ||
| v-tooltip="copied && $t('core.copied')" | ||
| :icon="faCopy" | ||
| size="medium" | ||
| accent="brand" | ||
| @click="copy(String(pif.gateway))" |
There was a problem hiding this comment.
I will not add comments on each section, but please refer to my previous comments about the v-if and String() parts
|
|
||
| const networkNbd = computed(() => (network.value?.nbd ? t('on') : t('off'))) | ||
|
|
||
| const status = computed(() => (pif?.attached ? 'connected' : 'disconnected')) |
There was a problem hiding this comment.
Suggested change
| const status = computed(() => (pif?.attached ? 'connected' : 'disconnected')) | |
| const status = computed(() => (pif.attached ? 'connected' : 'disconnected')) |
|
|
||
| const status = computed(() => (pif?.attached ? 'connected' : 'disconnected')) | ||
|
|
||
| const physicalInterfaceStatus = computed(() => (pif && pif.carrier ? 'connected' : 'physically-disconnected')) |
There was a problem hiding this comment.
I think this can be enough:
Suggested change
| const physicalInterfaceStatus = computed(() => (pif && pif.carrier ? 'connected' : 'physically-disconnected')) | |
| const physicalInterfaceStatus = computed(() => (pif.carrier ? 'connected' : 'physically-disconnected')) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sidebar to host networks view
Screenshot
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.mdReview process
Notes: