Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/createVm): fix OTHER_OPERATION_IN_PROGRESS #8399

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Mar 3, 2025

Description

wait for VDIs to be created before updating existing VDIs, otherwise VBD_create may return an error if a VDI is being migrated

may fix zammad#34862
Introduced by 04dd9e9

To reproduce

xo-cli vm.create name_label=foo template=3b1c096b-ba9e-a5c5-74e0-b1c006243f2c VDIs=json:['{"name_label":"test", "size": 10000, "type":"system", "SR":"86a9757d-9c05-9fe0-e79a-8243cb1f37f3"}'] existingDisks=json:'{"0":{"$SR":"87a388a1-c243-1da9-0fc1-63fa62a9b999"}}'

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@MathieuRA MathieuRA self-assigned this Mar 3, 2025
@MathieuRA MathieuRA requested a review from b-Nollet March 3, 2025 18:38
@b-Nollet b-Nollet requested a review from fbeauchamp March 5, 2025 16:10
@MathieuRA MathieuRA force-pushed the fix-vm-creation-migration branch from e260206 to 489ccf3 Compare March 6, 2025 16:49
@MathieuRA MathieuRA requested a review from b-Nollet March 6, 2025 16:49
@MathieuRA MathieuRA merged commit f310575 into master Mar 7, 2025
1 check passed
@MathieuRA MathieuRA deleted the fix-vm-creation-migration branch March 7, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants