fix seq wrap around

[vearne]

Summary by CodeRabbit

• New Features

  • Updated version number to v0.2.4 for improved clarity.
  • Enhanced testing for TCP buffer behavior under wrap-around conditions with new test cases.

• Bug Fixes

  • Improved handling of TCP sequence numbers to prevent overflow issues.

• Refactor

  • Simplified logic in TCP buffer management for better performance and concurrency handling.

• Tests

  • Renamed and adjusted existing test functions to validate new sequence number handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several updates across multiple files, primarily focusing on versioning and enhancements to TCP packet handling. The Makefile is modified to reflect a version increment from v0.2.3 to v0.2.4. In the http2/processor.go file, the handling of TCP packets is refined, particularly concerning sequence number management. The TCPBuffer structure in http2/tcp_buffer.go is updated to use atomic types for size management, improving concurrency. Additionally, the test cases in http2/tcp_buffer_test.go are modified and expanded to validate the new logic under wrap-around conditions for TCP sequence numbers.

Changes

File	Change Summary
Makefile	Updated VERSION from v0.2.3 to v0.2.4 and modified LDFLAGS to include the new version number.
http2/processor.go	Introduced payloadSize for TCP payload size, updated sequence number logic with modulo operation.
http2/tcp_buffer.go	Changed size and actualCanReadSize from uint32 to atomic.Int64; modified expectedSeq to uint32. Updated logic in AddTCP and Read methods for improved concurrency. Increased buffer size.
http2/tcp_buffer_test.go	Renamed TestSocketBufferDuplicate to TestSocketBufferWrapAround1, added TestSocketBufferWrapAround2 and TestSocketBufferWrapAround3. Updated sequence numbers for wrap-around testing.

Possibly related PRs

• http2/http2.go #22: This PR also updates the VERSION variable in the Makefile, indicating a version increment similar to the main PR.
• fix connection preface #25: Similar to the main PR, this PR updates the VERSION variable in the Makefile, reflecting a version change.
• fix bug:file appears multiple times #30: This PR modifies the VERSION variable in the Makefile, aligning with the version update in the main PR.
• Develop #33: This PR includes a version update in the Makefile, consistent with the version change in the main PR.
• Develop #36: This PR updates the VERSION variable in the Makefile, paralleling the version increment in the main PR.
• update http2/processor.go #51: Although this PR does not update the Makefile, it modifies the http2/processor.go file, which is relevant to the context of the main PR's changes in the build process.

🐇 In the meadow, we hop with glee,
A version change, oh what a spree!
TCP packets dance and play,
Atomic magic leads the way.
Tests now check for wraps around,
In code, new joy and peace abound! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.