-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): usage of a deprecated Node.js version
#21479
fix(ci): usage of a deprecated Node.js version
#21479
Conversation
@@ -41,7 +41,7 @@ jobs: | |||
env: | |||
CARGO_INCREMENTAL: 0 | |||
steps: | |||
- uses: actions/checkout@v3 | |||
- uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4
is the latest major version at the time of this pull request's creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hamirmahal !
* chore: changes from formatting on save * fix: usage of `a deprecated Node.js version`
Regression Detector ResultsRun ID: b0da171d-195b-4e69-a48b-331b450ea6c8 Metrics dashboard Baseline: e2afcdf Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | +3.09 | [-3.44, +9.63] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | otlp_http_to_blackhole | ingress throughput | +3.24 | [+3.06, +3.43] | |
➖ | file_to_blackhole | egress throughput | +3.09 | [-3.44, +9.63] | |
➖ | syslog_humio_logs | ingress throughput | +2.96 | [+2.79, +3.12] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +2.49 | [+2.29, +2.68] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +2.04 | [+1.96, +2.13] | |
➖ | http_text_to_http_json | ingress throughput | +0.54 | [+0.40, +0.68] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +0.48 | [+0.33, +0.62] | |
➖ | fluent_elasticsearch | ingress throughput | +0.48 | [-0.01, +0.97] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | +0.25 | [+0.14, +0.36] | |
➖ | http_to_http_acks | ingress throughput | +0.10 | [-1.13, +1.33] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | +0.08 | [-0.03, +0.18] | |
➖ | http_to_http_noack | ingress throughput | +0.06 | [+0.01, +0.11] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | +0.03 | [-0.06, +0.13] | |
➖ | http_to_http_json | ingress throughput | +0.02 | [-0.02, +0.05] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.09, +0.09] | |
➖ | socket_to_socket_blackhole | ingress throughput | +0.00 | [-0.07, +0.07] | |
➖ | http_to_s3 | ingress throughput | -0.02 | [-0.29, +0.26] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.02 | [-0.10, +0.06] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.08 | [-0.18, +0.02] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -0.14 | [-0.26, -0.02] | |
➖ | syslog_loki | ingress throughput | -0.15 | [-0.23, -0.07] | |
➖ | http_elasticsearch | ingress throughput | -0.30 | [-0.47, -0.13] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -1.84 | [-1.93, -1.75] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -2.02 | [-2.13, -1.91] | |
➖ | splunk_hec_route_s3 | ingress throughput | -2.16 | [-2.46, -1.85] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -2.60 | [-2.83, -2.38] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
7833a2a
You're welcome, @jszwedko! |
fixes #21478.