-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sources): multicast udp socket support #22099
base: master
Are you sure you want to change the base?
feat(sources): multicast udp socket support #22099
Conversation
This looks awesome🤯 |
Hi @nomalord perhaps you could test this? |
I don't really have experience with rust, but I'll try to compile the feature branch and update you🥹 |
Maybe this is helpful to you:
|
Thank you for popping in @pront 😃. I have left to include some tests to validate this PR and also add documentation & changelog. I will update this as soon as I can and mark the pr as non-draft then |
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
Hi @pront. Sorry for the delay, had no time these past weeks. Addressed all your comments and left a few doubts about the new changes. Feel free to resolve any conversation, just wanted to raise some things so you are aware of it. Thanks! |
small bump in case this got forgotten @pront, I think it is almost done. |
👍 I will take a look first thing tomorrow |
Unfortunately some windows tests failed: |
Hm, It is surprising that vector/src/sources/socket/mod.rs Line 1409 in cdd37cd
But can't understand why it is not working if Is there any easy way to run windows tests from linux? Or do I have to spin up a VM and configure everything there..? What we could do is to flag that test behind #[cfg(unix)] or delete it completely, as I think that test is a bit redundant, as we have |
Can't understand why the error is happening, as we always bind to |
I am afraid this is the way to go.
I wonder if this feature works on Windows, sounds like we never tested it on there. I have a feeling ti does but we don't want to merge it without testing it. If you don't want to go down that rabbit hole, we can start by advertising it as linux only (and apply |
no problem, I will try to run it all on windows! |
Closes #5732
This PR is still in draft. I have a few pending
TODOs
and also missing tests to propertly check this. Although, the happy path is working.In order to test this, use this vector config:
and with this command
you can see logs in vector.

I would like to receive some feedback about how the configuration of this setting should look like.
Also, note that IPv6 is not supported. We can work on that, but maybe it is not worth it if no one request that.
@nomalord take a look into this please, It would be great if you can build the binary from this branch and test if it works in your systems.
@dalesample as you were the first requester of this I also ping you, just in case (although this issue was created 4 years ago)