-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(websocket_server sink): add simple customizable extra metrics tags for websocket_server
#22484
base: master
Are you sure you want to change the base?
feat(websocket_server sink): add simple customizable extra metrics tags for websocket_server
#22484
Conversation
…gs for `websocket_server` This adds a new configuration option to `websocket_server` to enable adding additional tags to metrics generated by this component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback for style consistency.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor feedback.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @esensar
Co-authored-by: Pavlos Rontidis <pavlos.rontidis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a simple non-breaking suggestion.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Summary
This adds a new configuration option to
websocket_server
to enable adding additional tags to metrics generated by this component.Change Type
Is this a breaking change?
How did you test this PR?
Besides the added tests, I have tested Vector with the following config:
Does this PR include user facing changes?
Checklist
make check-all
is a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.