Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(internal docs): Fix dead link on commit sub-categories #22520

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

seunghunee
Copy link
Contributor

Summary

Fix dead link on commit sub-categories in CONTRIBUTING.md

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@seunghunee seunghunee requested a review from a team as a code owner February 26, 2025 12:49
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seunghunee

@pront pront enabled auto-merge February 26, 2025 14:06
@seunghunee
Copy link
Contributor Author

@pront, Do we need label no-changelog Changes in this PR do not need user-facing explanations in the release changelog here?

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Feb 28, 2025
@pront
Copy link
Member

pront commented Feb 28, 2025

Also, please do a git origin merge master and push to this PR

auto-merge was automatically disabled March 4, 2025 13:12

Head branch was pushed to by a user without write access

@seunghunee seunghunee force-pushed the docs/fix-dead-link branch from c42f4b6 to 03917cf Compare March 4, 2025 13:12
@seunghunee
Copy link
Contributor Author

Oh.. sorry I should've just merged and pushed it the way @pront said. auto-merge was disabled.

@pront pront enabled auto-merge March 4, 2025 16:10
@pront pront added this pull request to the merge queue Mar 4, 2025
Merged via the queue into vectordotdev:master with commit c3d0f08 Mar 4, 2025
42 checks passed
@seunghunee seunghunee deleted the docs/fix-dead-link branch March 5, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants