Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(external): add missing Quad9 credits in previous releases #22569

Merged

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Mar 3, 2025

Summary

This adds missing Quad9 credits in my PRs from previous releases, because that work was sponsored by Quad9.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

Sponsored by Quad9

This adds missing Quad9 credits in my PRs from previous releases, because that work was sponsored by
Quad9.
@esensar esensar requested review from a team as code owners March 3, 2025 09:51
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Mar 3, 2025
@esensar
Copy link
Contributor Author

esensar commented Mar 3, 2025

Is this an alright way to credit sponsorship in releases? I can see that multiple contributors are supported in changelog entries and release notes, so I figured that would be the best place to credit Quad9.

@pront
Copy link
Member

pront commented Mar 3, 2025

Hi @esensar, did you check how this renders? Otherwise, LGTM

@esensar
Copy link
Contributor Author

esensar commented Mar 3, 2025

Hi @esensar, did you check how this renders? Otherwise, LGTM

Yes, it looked alright, just listed both my name and Quad9 (with GH link) alongside each other.

@pront pront enabled auto-merge March 3, 2025 16:27
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 4, 2025
@pront pront changed the title chore(docs): add missing Quad9 credits in previous releases docs(external): add missing Quad9 credits in previous releases Mar 4, 2025
@pront pront added this pull request to the merge queue Mar 4, 2025
Merged via the queue into vectordotdev:master with commit d39ca73 Mar 4, 2025
42 of 45 checks passed
@esensar esensar deleted the chore/previous-releases-quad9-credits branch March 4, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants