Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Update permissions and revert id call #22580

Merged
merged 6 commits into from
Mar 5, 2025

Conversation

devindford
Copy link
Contributor

Summary

  • Updates the permissions so we can extract the artifact
  • Reverts the change to the id used to the previous one

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@devindford devindford added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Mar 3, 2025
@devindford devindford requested a review from a team as a code owner March 3, 2025 20:31
@pront pront changed the title fix(website-workflow): Update permissions and revert id call fix(website): Update permissions and revert id call Mar 3, 2025
@pront pront enabled auto-merge March 4, 2025 15:36
@pront pront added this pull request to the merge queue Mar 4, 2025
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: devin-ford-websites-trigger-update
Commit report: 4b96058
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 4, 2025
@devindford devindford added this pull request to the merge queue Mar 5, 2025
Merged via the queue into master with commit d0d770f Mar 5, 2025
43 checks passed
@devindford devindford deleted the devin-ford-websites-trigger-update branch March 5, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants