Add default value for adapter

vercel · Dec 17, 2024 · 8e5225e · 8e5225e
1 parent 103ad1e
commit 8e5225e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/packages/adapter-launchdarkly/src/index.ts b/packages/adapter-launchdarkly/src/index.ts
@@ -34,16 +34,20 @@ export function createLaunchDarklyAdapter({
   const edgeConfigClient = createClient(edgeConfigConnectionString);
   const ldClient = init(ldClientSideKey, edgeConfigClient);
 
-  return function launchDarklyAdapter<ValueType>({
-    defaultValue,
-  }: AdapterOptions<ValueType> = {}): Adapter<ValueType, LDContext> {
+  return function launchDarklyAdapter<ValueType>(
+    options: AdapterOptions<ValueType> = {},
+  ): Adapter<ValueType, LDContext> {
     return {
       origin(key) {
         return `https://app.launchdarkly.com/projects/${ldProject}/flags/${key}/`;
       },
-      async decide({ key, entities }): Promise<ValueType> {
+      async decide({ key, entities, defaultValue }): Promise<ValueType> {
         await ldClient.waitForInitialization();
-        return ldClient.variation(key, entities!, defaultValue) as ValueType;
+        return ldClient.variation(
+          key,
+          entities!,
+          options.defaultValue ?? defaultValue,
+        ) as ValueType;
       },
     };
   };

diff --git a/packages/flags/src/next/index.ts b/packages/flags/src/next/index.ts
@@ -280,6 +280,7 @@ function getRun<ValueType, EntitiesType>(
     try {
       decisionPromise = Promise.resolve<ValueType>(
         decide({
+          defaultValue: definition.defaultValue,
           headers: readonlyHeaders,
           cookies: readonlyCookies,
           entities,

diff --git a/packages/flags/src/sveltekit/index.ts b/packages/flags/src/sveltekit/index.ts
@@ -131,6 +131,7 @@ export function flag<T>(definition: FlagDeclaration<T, unknown>): Flag<T> {
       {
         headers: sealHeaders(store.event.request.headers),
         cookies: sealCookies(store.event.request.headers),
+        defaultValue: definition.defaultValue,
       },
       // @ts-expect-error not part of the type, but we supply it for convenience
       { event: store.event },

diff --git a/packages/flags/src/types.ts b/packages/flags/src/types.ts
@@ -130,6 +130,7 @@ export type GenerousOption<T> = boolean extends T
 export type Decide<ValueType, EntitiesType> = (
   params: FlagParamsType & {
     entities?: EntitiesType;
+    defaultValue?: ValueType;
   },
 ) => Promise<ValueType> | ValueType;
 
@@ -150,6 +151,7 @@ export interface Adapter<ValueType, EntitiesType> {
     entities?: EntitiesType;
     headers: ReadonlyHeaders;
     cookies: ReadonlyRequestCookies;
+    defaultValue?: ValueType;
   }) => Promise<ValueType> | ValueType;
 }