-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
throw on undefined unless defaultValue is defined #46
Merged
dferber90
merged 9 commits into
main
from
dferber/fla-1641-handle-flags-and-adapters-returning-undefined
Jan 24, 2025
Merged
throw on undefined unless defaultValue is defined #46
dferber90
merged 9 commits into
main
from
dferber/fla-1641-handle-flags-and-adapters-returning-undefined
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AndyBitz
approved these changes
Jan 23, 2025
68e733a
to
5bca4c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags may not return an
undefined
value, asundefined
can not be serialized.Specifically, the
decide
function may not return undefined unless adefaultValue
is provided.When a
decide
function returnsundefined
and nodefaultValue
was provided the flag will throw:When a
decide
function returnsundefined
and adefaultValue
was provided the defaultValue will be used:By default the
decide
function's types will not warn when you return undefined as you might have a defaultValue in place. Specify the flag type usingflag<boolean>
etc to ensure yourdecide
function may not returnundefined
on a typescript level.