-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Astro support #21
Closed
feugy
wants to merge
42
commits into
main
from
damien/aly-1082-astro-support-in-vercelspeed-insights
Closed
feat: Astro support #21
feugy
wants to merge
42
commits into
main
from
damien/aly-1082-astro-support-in-vercelspeed-insights
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: outdated names and links in the readme
Co-authored-by: Tobias Lins <me@tobi.sh>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6b66881
to
7716deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 What's in there?
This PR brings Astro first-class support with a dedicated component.
🧪 How to test?
There's a new example application.
pnpm -F @vercel/speed-insights build
pnpm i
apps/astro/src/components/BaseHead.astro
to add<SpeedInsights scriptSrc="https://va.vercel-scripts.com/v1/speed-insights/script.js">
cd apps/astro && pnpm dev
❗ Notes to reviewers
This component is one-of-its-kind: we don't want to bundle it with
tsup
like for Vue, Sveltekit, React or Next.Astro will care of packaging it when it'll bundle the customer's astro app.
So this index.astro file is copied after running tsup directly into
dist/
This is draft until we find a way to pass
beforeSend
toinjectSpeedInsights()
utility