Implement the Starlark index expression assignment operation#497

Merged

sharifelgamal merged 9 commits intomasterfrom allow-set-indexable

May 7, 2024

+533-453

Commits on May 6, 2024

CSL3-2071 CSL3-2108 - Case Insensitive headers test
kochniev
committed
Failing test demonstrating issue with assignment of d["key"] = "one" throwing an exception.
mahmoudimus
committed
We introduce StarlarkSetIndexable to allow setIndex, similar to
mahmoudimus
committed
Update tests to support usage pattern
mahmoudimus
committed
Update LarkyIndexable to support __setitem__ and implement the new StarlarkSetIndexable(.Threaded) interface
mahmoudimus
committed
And now, we do not need StarlarkMapping any longer since we can fulfill the exact same interface with LarkyMapping. Delete StarlarkMapping and move the functionality to LarkyMapping
mahmoudimus
committed
Fix incorrect test syntax -- there is no .size() in Python, only len(dict) for cardinality checks
mahmoudimus
committed
we do not have a base itemview class in larky, so we cannot compare classes to primitives in larky (as we would do in python). as a result, we have to return a raw list on the view instead of an ac…
mahmoudimus
committed
We make the final modification to get the test to pass!
mahmoudimus
committed