Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSL3-2519] Use correct IV length for AES CBC #570

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CSL3-2519] Use correct IV length for AES CBC #570

wants to merge 2 commits into from

Conversation

viacheslav-rud
Copy link
Contributor

@viacheslav-rud viacheslav-rud commented Jan 15, 2025 •
edited
Loading

Fixes Jira Story or GH Issue if applicable

Description of changes in release / Impact of release:

(insert text here)

Documentation

(insert text here)

Risks of this release

Is this a breaking change?

  • Yes
  • No

If you answered Yes then describe why is it so

(insert text here if applicable)

Is there a way to disable the change?

  • Use previous release
  • Use a feature flag
  • No

Additional details go here

(insert text here if applicable)

mjallday
mjallday requested changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@mjallday mjallday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code doesn’t mirror the original change from the upstream repo. Please help me understand why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjallday mjallday mjallday requested changes

@Iapetus999 Iapetus999 Iapetus999 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viacheslav-rud @mjallday @Iapetus999