Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

refactor: split pros up into several smaller subcrates #86

Merged
merged 32 commits into from
Mar 1, 2024
Merged

refactor: split pros up into several smaller subcrates #86

merged 32 commits into from
Mar 1, 2024

Conversation

Gavin-Niederman
Copy link
Member

Describe the changes this PR makes. Why should it be merged?

This PR splits up the large pros crate into multiple smaller subcrates. The pros crate no longer has any code of its own, but instead re-exports from the subcrates based on what features are enabled.
This closes #9.

Additional Context

  • These are breaking changes (semver: major).
  • These changes update the crate's interface (e.g. functions/modules added or changed).

@Gavin-Niederman Gavin-Niederman added semver:major Changes the existing API in a backward-incompatible manner type:refactor Updates internals without changing API interface labels Feb 4, 2024
@Gavin-Niederman Gavin-Niederman marked this pull request as ready for review February 10, 2024 21:50
Tropix126
Tropix126 suggested changes Feb 11, 2024
View reviewed changes
packages/pros-core/src/pros_alloc/mod.rs Outdated Show resolved Hide resolved
packages/pros-core/src/competition.rs Outdated Show resolved Hide resolved
packages/pros-sync/src/lib.rs Outdated Show resolved Hide resolved
@Gavin-Niederman Gavin-Niederman force-pushed the metapackage branch 2 times, most recently from ba03adf to 958ded0 Compare February 12, 2024 07:33
doinkythederp
doinkythederp suggested changes Feb 15, 2024
View reviewed changes
packages/pros-devices/src/lib.rs Outdated Show resolved Hide resolved
packages/pros-devices/src/screen.rs Outdated Show resolved Hide resolved
packages/pros-devices/src/smart/mod.rs Outdated Show resolved Hide resolved
packages/pros-devices/src/smart/mod.rs Outdated Show resolved Hide resolved
packages/pros-sys/src/motor.rs Show resolved Hide resolved
packages/pros/Cargo.toml Show resolved Hide resolved
packages/pros/src/lib.rs Show resolved Hide resolved
packages/pros/src/lib.rs Show resolved Hide resolved
packages/pros-devices/src/adi/mod.rs Outdated Show resolved Hide resolved
packages/pros-core/src/task/mod.rs Show resolved Hide resolved
@Gavin-Niederman Gavin-Niederman added this to the 0.8.0 milestone Feb 16, 2024
doinkythederp
doinkythederp previously requested changes Feb 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Tropix126
Tropix126 approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Tropix126 Tropix126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gavin-Niederman
refactor: move competition module into pros_devices
0ac520f
@Gavin-Niederman
docs(pros-sync): update outdated module docs
5d6daba
@Gavin-Niederman
chore: format
2c29b65
@Gavin-Niederman
docs: fix ADI examples
e65faf9
@Gavin-Niederman
docs: improve changelog entry
14ea595
@Gavin-Niederman
fix: update ADI pwm module imports
aee2f96
@Gavin-Niederman
chore: format
7e0f676
@Gavin-Niederman
docs: improve links in docs
2abfea0
@Gavin-Niederman
feat: pros now depends on and exports pros-sys
9aacd2c
@Gavin-Niederman
fix: use a real version of pros-sys
579a44b
@Gavin-Niederman
docs: fix grammar issues and repetition
f6d1ae5
@Gavin-Niederman
docs: remove duplicate changelog entry
0951065
@Gavin-Niederman
feat: create pros-math crate and bring back pid and feedforward contr…
d545b2e 
…ollers
@Gavin-Niederman
docs: update added crates in changelog
8041103
@Gavin-Niederman
chore: formatting
2fedca0
@Gavin-Niederman
refactor: rename pros_alloc module to allocator
99c803b
@Gavin-Niederman
chore: format
1c54299
@Gavin-Niederman
refactor: disable sync feature by default
fd5bc09
@Gavin-Niederman
fix: use associated screen constants in panic handler
be01cda
@Gavin-Niederman Gavin-Niederman dismissed doinkythederp’s stale review March 1, 2024 20:31

all of the points have been adressed

@Gavin-Niederman Gavin-Niederman merged commit 61b560b into main Mar 1, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tropix126 Tropix126 Tropix126 approved these changes

@doinkythederp doinkythederp Awaiting requested review from doinkythederp

Assignees
No one assigned
Labels
semver:major Changes the existing API in a backward-incompatible manner type:refactor Updates internals without changing API interface
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

Split pros crate into multiple smaller sub-crates
3 participants
@Gavin-Niederman @Tropix126 @doinkythederp