Skip to content

Commit

Permalink
[MTGOSDK/API/Play] Tournaments: Minor .NET 8 fixes, access optimizati…
Browse files Browse the repository at this point in the history
…ons.
  • Loading branch information
Qonfused committed Dec 20, 2023
1 parent b37f81f commit d94064d
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 7 deletions.
2 changes: 1 addition & 1 deletion MTGOSDK/src/API/Play/Tournaments/GameStandingRecord.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public sealed class GameStandingRecord(dynamic gameStandingRecord)
/// <remarks>
/// Requires the <c>WotC.MTGO.Common</c> reference assembly.
/// </remarks>
public GameState GateState =>
public GameState GameState =>
Cast<GameState>(Unbind(@base).GameState);

/// <summary>
Expand Down
28 changes: 23 additions & 5 deletions MTGOSDK/src/API/Play/Tournaments/MatchStandingRecord.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,39 @@ public IEnumerable<User> Players
get
{
foreach(var player in @base.Users)
yield return new User(player.Id, player.Name);
yield return new User(player.Name);
}
}

/// <summary>
/// The IDs of the winning player(s).
/// </summary>
public IList<int> WinningPlayerIds =>
Map<int>(@base.WinningPlayerIds).ToList();
public IList<int> WinningPlayerIds // FIXME: .NET 8 DLR regression
{
get
{
IList<int> winningPlayerIds = new List<int>();
foreach(var playerId in @base.WinningPlayerIds)
winningPlayerIds.Add(playerId);

return winningPlayerIds;
}
}

/// <summary>
/// The IDs of the losing player(s).
/// </summary>
public IList<int> LosingPlayerIds =>
Map<int>(@base.LosingPlayerIds).ToList();
public IList<int> LosingPlayerIds // FIXME: .NET 8 DLR regression
{
get
{
IList<int> losingPlayerIds = new List<int>();
foreach(var playerId in @base.LosingPlayerIds)
losingPlayerIds.Add(playerId);

return losingPlayerIds;
}
}

/// <summary>
/// The results of each game in the match.
Expand Down
2 changes: 1 addition & 1 deletion MTGOSDK/src/API/Play/Tournaments/StandingRecord.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public sealed class StandingRecord(dynamic standingRecord)
/// <summary>
/// The user object of the player.
/// </summary>
public User Player => new(@base.User);
public User Player => new(@base.User.Name);

/// <summary>
/// The number of points the player has earned.
Expand Down

0 comments on commit d94064d

Please sign in to comment.