Refactor RemoteNET projects #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the RemoteNET and ScubaDiver.API libraries into the main MTGOSDK project. This allows for tighter coupling of the type-marshalling/proxy protocol being developed for the main library, which should be preferred over the previous RemoteNET approach. TODO: Refactor and deduplicate RemoteNET + API architecture
Qonfused
commented
Mar 30, 2024
Qonfused
force-pushed
the
refactor-remotenet
branch
from
3367019 to
c120cf7
Compare
Qonfused
force-pushed
the
refactor-remotenet
branch
3 times, most recently
from
ef6bd74 to
cd114b6
Compare
Qonfused
added a commit
that referenced
this pull request
May 24, 2024
Removes an old workaround for fetching unbound dynamic objects before binding the interface type in reflection cache. Due to architectural changes in #13 this is no longer needed and can be removed to fully harden security of the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a major refactor of the RemoteNET projects, merging the RemoteNET and ScubaDiver.API projects with the
MTGOSDK.Core.Remotingnamespace. This accompanies fixes across RemoteNET projects to simplify the project architecture and make it more consistent with the rest of the library.The MTGOSDK library also has an additional netstandard2.0 target, which exports only the
MTGOSDK.Corenamespace. This is used by the ScubaDiver assembly to import the internal (RemoteNET) API from theMTGOSDK.Core.Remoting.Interopnamespace.