Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize ScubaDiver API #23

Merged
merged 13 commits into from
Nov 6, 2024
Merged

Modularize ScubaDiver API #23

merged 13 commits into from
Nov 6, 2024

Conversation

Qonfused
Copy link
Member

@Qonfused Qonfused commented Sep 19, 2024

Separates Diver endpoints into separate classes/services to allow for later refactoring in #4. Additionally replaces the Newtonsoft.Json dependency with System.Text.Json for improved serialization/deserialization performance and lower peak memory usage.

Tasks

Preview Give feedback

@Qonfused Qonfused self-assigned this Sep 19, 2024
@Qonfused Qonfused force-pushed the main branch 6 times, most recently from 37168ea to de56011 Compare October 27, 2024 23:39
@Qonfused Qonfused changed the title Refactor ScubaDiver Refactor ScubaDiver API Nov 4, 2024
@Qonfused Qonfused force-pushed the refactor-scubadiver branch from b4f030b to 58923ac Compare November 4, 2024 21:18
commit 035a6b1
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Sep 15 14:21:51 2024 -0500

    Use System.Text.Json for JSON serialization

commit 09c4d36
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Sep 15 13:06:35 2024 -0500

    Set version to '0.0-preview2'

commit a10a56a
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Sep 15 13:06:19 2024 -0500

    Remove unneeded Newtonsoft.Json reference

commit 50898b0
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Sat Sep 14 22:12:02 2024 -0500

    Set version to '0.0-preview'

commit 1587282
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Sat Sep 14 20:46:37 2024 -0500

    Simplify version.json

    Allows for managing branch + tag workflows with the `dotnet nbgv prepare-release` command.

commit 5fd35fa
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Sat Sep 14 20:43:38 2024 -0500

    Do not manage private feeds on Linux/macOS

    Avoids pruning existing local feeds when the `nuget.exe` executable cannot be run.

commit e5067c7
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Fri Sep 13 11:46:46 2024 -0500

    README: Cleanup SDK Feed example

commit 06dca10
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Fri Sep 13 09:20:59 2024 -0500

    README: Update build instructions and usage example

commit f06d643
Author: Cory Bennett <32466081+Qonfused@users.noreply.github.com>
Date:   Wed Sep 11 08:36:39 2024 -0500

    README: Fix MTGO version badge

    Uses the [`api.videreproject.com/mtgo/manifest`](https://api.videreproject.com/mtgo/manifest) endpoint to fetch the current MTGO version.

commit a278117
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Sep 8 13:11:02 2024 -0500

    [MTGOSDK/Core/Remoting] Expose FullName in RemoteAssembly proxy

    Allows for retrieving the full name of a proxied type when traversing the parent assembly proxy.

commit e2577a6
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Aug 18 09:29:28 2024 -0500

    [MTGOSDK/API] Client: Rename CloseOnExit option

commit 43d839d
Author: Cory Bennett <csquaredbennett@gmail.com>
Date:   Sun Aug 18 09:28:51 2024 -0500

    [MTGODSK/Core/Reflection] DLRWrapper: Update unbind fallbacks

    Ensure that calls to `Unbind(DLRWrapper obj)` always return the base object.
@Qonfused Qonfused force-pushed the refactor-scubadiver branch from 58923ac to 3b6d34e Compare November 4, 2024 21:29
@Qonfused Qonfused force-pushed the refactor-scubadiver branch from 4ccc997 to a3ca1ac Compare November 5, 2024 04:33
@Qonfused
Copy link
Member Author

Qonfused commented Nov 5, 2024

Reverted migration to System.Text.Json due to incompatibilities with ILLink trimming. Migrating to gRPC in a separate PR will be a better optimization path forward.

@Qonfused Qonfused marked this pull request as ready for review November 5, 2024 07:17
@Qonfused Qonfused changed the title Refactor ScubaDiver API Modularize ScubaDiver API Nov 5, 2024
@Qonfused Qonfused merged commit b1cd8fb into main Nov 6, 2024
2 checks passed
@Qonfused Qonfused deleted the refactor-scubadiver branch November 7, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant