Fix Avatar, ChannelManager references #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-expose public property access (which is no longer exposed through the IShellViewModel interface).
Qonfused
changed the title
As Avatars now have separate image and shader `ImageSource` resources, they no longer alias an IVisualResource in the Avatar class. This can still be referenced in the CardDefinition instance, which we use to better indicate the current loading state of the Avatar's visual resources.
Use Card ID as Avatar ID property.
Prune explicit IVisualResource reference.
Prevents passing an unbound DRO to the Card constructor.
Qonfused
added
status:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #27 and #29 following recent changes to Avatar resources and IShellViewModel properties.