-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python tests in justfile with nix #331
Conversation
Still isnt ready to merge because im getting a strange behavior with the tests being executed by |
e8cda76
to
34a3814
Compare
@Davidson-Souza This error from actions is happening because i had to change the way that Seeing your interest in increasing our use of nix in this repo(supposed by #335 ), the problem can be solved by using only nix to setup and run the tests inside |
I don't want to tie our development to nix (I don't use nix). It's cool for specific things like #335, but I wouldn't make it a requirement for development. |
5d2d073
to
0f79c64
Compare
@Davidson-Souza what did you think of the solution of f025e0e and 0f79c64 ?
This avoids a user that has florestad installed in their $PATH not conflict with the tests that hes doing and also removes the cargo dependencie while calling floresta in our framework without changing it too much. This makes it able to run inside nix without too much trouble... the deterministic builds of #335 will thank this change |
Seems ok, I concept ACK this (haven't tested yet) |
0f79c64
to
370182a
Compare
dont merge, just triggering actions. |
9698040
to
8be5a2c
Compare
It works! Ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK. I just have a few small requests before we can merge
Applied suggestions by @Davidson-Souza |
8be5a2c
to
75e2a93
Compare
oh, sorry |
75e2a93
to
b2462db
Compare
This piece of changes tries to automate our python tests inside our justfile.
test-int
now just executes"poetry run poe tests"
command defined inpyproject.toml
and inrun_tests.py
.the old
test-int
is renamed totest-wkspc
to match better the internal command and to give space for the integration tests with python.new command
test-int-nix
uses a nix-shell to setup every python crap, downloading and compiling utreexod and florestad, run the tests and exits