update CI

fix coverage
delete unused code

.github/workflows/build-test.yml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.10", "3.11", "3.12"]
+        python-version: ["3.11", "3.12", "3.13"]
         os: [ubuntu-latest, windows-latest, macos-latest]
     steps:
     - uses: actions/checkout@v4

.github/workflows/coverage.yml

@@ -14,9 +14,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [ "3.11" ]
+        python-version: [ "3.12" ]
     steps:
     - uses: actions/checkout@v4
+      with:
+        fetch-depth: 0
     - name: "pip: Python ${{ matrix.python-version }} coverage"
       uses: actions/setup-python@v5
       with:
@@ -27,7 +29,7 @@ jobs:
         python -m pip install pybind11 pytest
     - name: Build
       run: |
-        CFLAGS=-coverage python -m pip install .
+        CXXFLAGS=-coverage python -m pip install .
     - name: Test
       run: |
         python -m pytest

.github/workflows/mpi-test.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.11"]
+        python-version: ["3.12"]
     steps:
       - uses: actions/checkout@v4
       - name: "pip: Python ${{ matrix.python-version }}"

codecov.yml

@@ -6,4 +6,4 @@ coverage:
         threshold: 1%  # leeway
     patch:
       default:
-        target: 80%
+        target: 75%

pyproject.toml

@@ -2,7 +2,7 @@
 requires = [
     "setuptools>=42",
     "wheel",
-    "pybind11>=2.6.0",
+    "pybind11>=2.13",
     "numpy",
     "pytest"
 ]

src/Model.cpp

@@ -4,7 +4,6 @@
 #include "Module.h"
 #include "Timer.h"
 #include "Log.h"
-#include "Error.h"
 #include "Helpers.h"
 
 #include <pybind11/pybind11.h>

src/Module.cpp

@@ -7,7 +7,6 @@
 #include "NPArray.h"
 #include "DataFrame.h"
 #include "Log.h"
-#include "Error.h"
 
 #include "NewOrder.h"
 
@@ -223,6 +222,6 @@ PYBIND11_MODULE(_neworder_core, m)
   init_env(mpi);
 
   // Map custom C++ exceptions to python ones
-  py::register_exception_translator(no::exception_translator);
+  //py::register_exception_translator(no::exception_translator);
 }
 

src/Timeline.cpp

@@ -1,6 +1,5 @@
 #include "Timeline.h"
 #include "Log.h"
-#include "Error.h"
 
 #include <pybind11/chrono.h>
 

test/test_model.py

@@ -18,6 +18,18 @@ def __init__(self) -> None:
     with pytest.raises(TypeError):
         _ = TestModel()
 
+def test_not_implemented() -> None:
+
+    class TestModel(no.Model):
+        def __init__(self) -> None:
+            super().__init__(no.NoTimeline())
+
+        def step(self) -> None:
+            raise NotImplementedError()
+
+    with pytest.raises(NotImplementedError):
+        no.run(TestModel())
+
 
 def test_default_seeder() -> None:
     class DefaultModel(no.Model):