Sev snp enhancements v1 #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LaunchDigest* routines assume that the VMM is EC2. This patch allows these routines to take the VMM type as a parameter instead, allowing measurement for QEMU. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Ian Chin Wang <ian.chin.wang@oracle.com>
The launch digest should also include the vcpu_signature to match the hardware measurement. This patch adds a vcpu_type parameter to the LaunchDigest* routines, which is used to look up the CPU signature from the existing CpuSigs table. If vcpu_type is unspecified, it defaults to using a signature value of 0. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Ian Chin Wang <ian.chin.wang@oracle.com>
OVMF hash formatting for JSON needs to be more consistent. The Marshaling routing adds a '0x' prefix, which the unmarshaling routine doesn't account for. This change discards the '0x' prefix when marshaling. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Ian Chin Wang <ian.chin.wang@oracle.com>
CpuSigs is missing the signature for AMD Genoa processors; this patch adds it. Signed-off-by: Jagannathan Raman <jag.raman@oracle.com> Reviewed-by: Ian Chin Wang <ian.chin.wang@oracle.com>
|
@derpsteb Hi there. Could you please confirm whether this pull request looks good? Thank you so much! |
derpsteb
approved these changes
May 21, 2024
Signed-off-by: Jag Raman <jraman567@gmail.com>
derpsteb
approved these changes
May 22, 2024
|
@derpsteb Could you please merge this pull request? |
|
Closing this one as resolved by #5 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This pull request adds miscellaneous patches to address minor issues in computing the launch digest and formatting MetadataWrapper as a JSON.
Thank you!