Fix MacOS and Windows compilation

.github/workflows/test.yml

@@ -2,8 +2,8 @@ on: [push, pull_request]
 name: test
 jobs:
   sw-openssl:
-    name: sw openssl ${{ matrix.toolchain }} ${{ matrix.profile.name }} ${{ matrix.features }}
-    runs-on: ubuntu-latest
+    name: sw openssl ${{ matrix.runner }} ${{ matrix.toolchain }} ${{ matrix.profile.name }} ${{ matrix.features }}
+    runs-on: ${{ matrix.runner }}
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
@@ -14,6 +14,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        runner:
+          - ubuntu-latest
+          - macos-12
         toolchain:
           - 1.70.0
           - stable
@@ -25,8 +28,8 @@ jobs:
           - openssl
 
   sw-crypto_nossl:
-    name: sw crypto_nossl ${{ matrix.toolchain }} ${{ matrix.profile.name }} ${{ matrix.features }}
-    runs-on: ubuntu-latest
+    name: sw crypto_nossl ${{ matrix.runner }} ${{ matrix.toolchain }} ${{ matrix.profile.name }} ${{ matrix.features }}
+    runs-on: ${{ matrix.runner }}
     steps:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
@@ -36,6 +39,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        runner:
+          - ubuntu-latest
+          - macos-12
+          - windows-latest
         toolchain:
           - 1.70.0
           - stable

Cargo.toml

@@ -69,7 +69,9 @@ x509-cert = { version = "0.2.5", optional = true }
 byteorder = "1.4.3"
 base64 = "0.22.0"
 
-[dev-dependencies]
+[target.'cfg(target_os = "linux")'.dev-dependencies]
 kvm-ioctls = ">=0.12"
+
+[dev-dependencies]
 kvm-bindings = ">=0.6"
 serial_test = "3.0"

README.md

@@ -11,7 +11,7 @@ Firmware (SNP)] (https://www.amd.com/content/dam/amd/en/documents/epyc-technical
 
 ### SEV APIs
 
-The Linux kernel exposes two technically distinct AMD SEV APIs:
+The linux kernel exposes two technically distinct AMD SEV APIs:
 
 1. An API for managing the SEV platform itself
 2. An API for managing SEV-enabled KVM virtual machines
@@ -21,7 +21,7 @@ code through a flexible and type-safe high-level interface.
 
 ### SNP ABIs
 
-Like SEV, the Linux kernel exposes another two different AMD SEV-SNP ABIs:
+Like SEV, the linux kernel exposes another two different AMD SEV-SNP ABIs:
 
 1. An ABI for managing the SEV-SNP platform itself
 2. An ABI for managing SEV-SNP enabled KVM virtual machines
@@ -62,7 +62,7 @@ and enabling both at the same time leads to a compiler error.
 
 ### Remarks
 
-Note that the Linux kernel provides access to these APIs through a set
+Note that the linux kernel provides access to these APIs through a set
 of `ioctl`s that are meant to be called on device nodes (`/dev/kvm` and
 `/dev/sev`, to be specific). As a result, these `ioctl`s form the substrate
 of the `sev` crate. Binaries that result from consumers of this crate are

src/firmware/host/types/snp.rs

@@ -5,7 +5,10 @@ pub use crate::firmware::linux::host::types::RawData;
 
 pub(crate) use crate::firmware::linux::host as FFI;
 
-use crate::{firmware::host::CertError, Version};
+use crate::Version;
+
+#[cfg(target_os = "linux")]
+use crate::error::CertError;
 
 use std::{
     convert::{TryFrom, TryInto},
@@ -172,11 +175,13 @@ impl CertTableEntry {
     }
 
     /// Builds a Kernel formatted CertTable for sending the certificate content to the PSP.
+    #[cfg(target_os = "linux")]
     pub fn cert_table_to_vec_bytes(table: &[Self]) -> Result<Vec<u8>, CertError> {
         FFI::types::CertTableEntry::uapi_to_vec_bytes(table)
     }
 
     /// Takes in bytes in kernel CertTable format and returns in user API CertTable format.
+    #[cfg(target_os = "linux")]
     pub fn vec_bytes_to_cert_table(bytes: &mut [u8]) -> Result<Vec<Self>, CertError> {
         let cert_bytes_ptr: *mut FFI::types::CertTableEntry =
             bytes.as_mut_ptr() as *mut FFI::types::CertTableEntry;

src/firmware/linux/host/types/snp.rs

@@ -5,6 +5,7 @@ use crate::error::CertError;
 
 use crate::firmware::host as UAPI;
 
+#[cfg(target_os = "linux")]
 use uuid::Uuid;
 
 /// Raw certificate bytes (by pointer or Vec<u8>).
@@ -163,6 +164,7 @@ impl CertTableEntry {
     /// };
     /// ```
     ///
+    #[cfg(target_os = "linux")]
     pub unsafe fn parse_table(
         mut data: *mut CertTableEntry,
     ) -> Result<Vec<UAPI::CertTableEntry>, uuid::Error> {
@@ -305,6 +307,7 @@ mod test {
         }
     }
 
+    #[cfg(target_os = "linux")]
     mod cert_table_entry {
 
         use crate::firmware::host as UAPI;